From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968078AbcHBQvZ (ORCPT ); Tue, 2 Aug 2016 12:51:25 -0400 Received: from mga03.intel.com ([134.134.136.65]:48375 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933109AbcHBMAY (ORCPT ); Tue, 2 Aug 2016 08:00:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743076733" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, corbet@lwn.net, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com Subject: [PATCH 0527/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:21:03 +0800 Message-Id: <20160802112103.17092-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/platform/marvell-ccic/mcam-core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c index 9b878de..4b3515c 100644 --- a/drivers/media/platform/marvell-ccic/mcam-core.c +++ b/drivers/media/platform/marvell-ccic/mcam-core.c @@ -47,7 +47,7 @@ */ static bool alloc_bufs_at_read; -module_param(alloc_bufs_at_read, bool, 0444); +module_param(alloc_bufs_at_read, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(alloc_bufs_at_read, "Non-zero value causes DMA buffers to be allocated when the " "video capture device is read, rather than at module load " @@ -56,13 +56,13 @@ MODULE_PARM_DESC(alloc_bufs_at_read, "only used in the vmalloc buffer mode"); static int n_dma_bufs = 3; -module_param(n_dma_bufs, uint, 0644); +module_param(n_dma_bufs, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(n_dma_bufs, "The number of DMA buffers to allocate. Can be either two " "(saves memory, makes timing tighter) or three."); static int dma_buf_size = VGA_WIDTH * VGA_HEIGHT * 2; /* Worst case */ -module_param(dma_buf_size, uint, 0444); +module_param(dma_buf_size, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dma_buf_size, "The size of the allocated DMA buffers. If actual operating " "parameters require larger buffers, an attempt to reallocate " @@ -73,13 +73,13 @@ static const int n_dma_bufs = 3; /* Used by S/G_PARM */ #endif /* MCAM_MODE_VMALLOC */ static bool flip; -module_param(flip, bool, 0444); +module_param(flip, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(flip, "If set, the sensor will be instructed to flip the image " "vertically."); static int buffer_mode = -1; -module_param(buffer_mode, int, 0444); +module_param(buffer_mode, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(buffer_mode, "Set the buffer mode to be used; default is to go with what " "the platform driver asks for. Set to 0 for vmalloc, 1 for " -- 2.9.2