From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933240AbcHBMAm (ORCPT ); Tue, 2 Aug 2016 08:00:42 -0400 Received: from mga14.intel.com ([192.55.52.115]:25346 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933074AbcHBMAL (ORCPT ); Tue, 2 Aug 2016 08:00:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033580989" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com, niklas.soderlund+renesas@ragnatech.se Subject: [PATCH 0536/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:21:54 +0800 Message-Id: <20160802112154.17693-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/radio/radio-aztech.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-aztech.c b/drivers/media/radio/radio-aztech.c index 705dd6f..f3499a1 100644 --- a/drivers/media/radio/radio-aztech.c +++ b/drivers/media/radio/radio-aztech.c @@ -45,9 +45,9 @@ static int io[AZTECH_MAX] = { [0] = CONFIG_RADIO_AZTECH_PORT, static int radio_nr[AZTECH_MAX] = { [0 ... (AZTECH_MAX - 1)] = -1 }; static const int radio_wait_time = 1000; -module_param_array(io, int, NULL, 0444); +module_param_array(io, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(io, "I/O addresses of the Aztech card (0x350 or 0x358)"); -module_param_array(radio_nr, int, NULL, 0444); +module_param_array(radio_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(radio_nr, "Radio device numbers"); struct aztech { -- 2.9.2