From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935485AbcHBQpK (ORCPT ); Tue, 2 Aug 2016 12:45:10 -0400 Received: from mga03.intel.com ([134.134.136.65]:14946 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933406AbcHBMAu (ORCPT ); Tue, 2 Aug 2016 08:00:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028263948" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, niklas.soderlund+renesas@ragnatech.se Subject: [PATCH 0544/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:22:44 +0800 Message-Id: <20160802112245.18233-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/radio/radio-zoltrix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-zoltrix.c b/drivers/media/radio/radio-zoltrix.c index 026e88e..8015866 100644 --- a/drivers/media/radio/radio-zoltrix.c +++ b/drivers/media/radio/radio-zoltrix.c @@ -65,9 +65,9 @@ static int io[ZOLTRIX_MAX] = { [0] = CONFIG_RADIO_ZOLTRIX_PORT, [1 ... (ZOLTRIX_MAX - 1)] = -1 }; static int radio_nr[ZOLTRIX_MAX] = { [0 ... (ZOLTRIX_MAX - 1)] = -1 }; -module_param_array(io, int, NULL, 0444); +module_param_array(io, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(io, "I/O addresses of the Zoltrix Radio Plus card (0x20c or 0x30c)"); -module_param_array(radio_nr, int, NULL, 0444); +module_param_array(radio_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(radio_nr, "Radio device numbers"); struct zoltrix { -- 2.9.2