From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967999AbcHBQsf (ORCPT ); Tue, 2 Aug 2016 12:48:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:21659 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933203AbcHBMAh (ORCPT ); Tue, 2 Aug 2016 08:00:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033581946" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, hverkuil@xs4all.nl, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, niklas.soderlund+renesas@ragnatech.se Subject: [PATCH 0546/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:22:55 +0800 Message-Id: <20160802112255.18367-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/radio/si470x/radio-si470x-i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c index 471d6a8..a4d8871 100644 --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -54,12 +54,12 @@ MODULE_DEVICE_TABLE(i2c, si470x_i2c_id); /* Radio Nr */ static int radio_nr = -1; -module_param(radio_nr, int, 0444); +module_param(radio_nr, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(radio_nr, "Radio Nr"); /* RDS buffer blocks */ static unsigned int rds_buf = 100; -module_param(rds_buf, uint, 0444); +module_param(rds_buf, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(rds_buf, "RDS buffer entries: *100*"); /* RDS maximum block errors */ @@ -68,7 +68,7 @@ static unsigned short max_rds_errors = 1; /* 1 means 1-2 errors requiring correction (used by original USBRadio.exe) */ /* 2 means 3-5 errors requiring correction */ /* 3 means 6+ errors or errors in checkword, correction not possible */ -module_param(max_rds_errors, ushort, 0644); +module_param(max_rds_errors, ushort, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_rds_errors, "RDS maximum block errors: *1*"); -- 2.9.2