From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933782AbcHBMDJ (ORCPT ); Tue, 2 Aug 2016 08:03:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:3346 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933649AbcHBMBm (ORCPT ); Tue, 2 Aug 2016 08:01:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018205997" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, david@hardeman.nu, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, max@duempel.org Subject: [PATCH 0555/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:23:55 +0800 Message-Id: <20160802112355.18976-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/tuners/mt20xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/tuners/mt20xx.c b/drivers/media/tuners/mt20xx.c index 9e03104..eff1852 100644 --- a/drivers/media/tuners/mt20xx.c +++ b/drivers/media/tuners/mt20xx.c @@ -12,19 +12,19 @@ #include "mt20xx.h" static int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "enable verbose debug messages"); /* ---------------------------------------------------------------------- */ static unsigned int optimize_vco = 1; -module_param(optimize_vco, int, 0644); +module_param(optimize_vco, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static unsigned int tv_antenna = 1; -module_param(tv_antenna, int, 0644); +module_param(tv_antenna, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static unsigned int radio_antenna; -module_param(radio_antenna, int, 0644); +module_param(radio_antenna, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* ---------------------------------------------------------------------- */ -- 2.9.2