From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967056AbcHBQmI (ORCPT ); Tue, 2 Aug 2016 12:42:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:27841 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932777AbcHBMBz (ORCPT ); Tue, 2 Aug 2016 08:01:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018206270" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, mkrufky@linuxtv.org, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, max@duempel.org Subject: [PATCH 0558/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:24:13 +0800 Message-Id: <20160802112413.19179-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/tuners/mxl5007t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/tuners/mxl5007t.c b/drivers/media/tuners/mxl5007t.c index f4ae04c..d44fd7d 100644 --- a/drivers/media/tuners/mxl5007t.c +++ b/drivers/media/tuners/mxl5007t.c @@ -28,7 +28,7 @@ static DEFINE_MUTEX(mxl5007t_list_mutex); static LIST_HEAD(hybrid_tuner_instance_list); static int mxl5007t_debug; -module_param_named(debug, mxl5007t_debug, int, 0644); +module_param_named(debug, mxl5007t_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "set debug level"); /* ------------------------------------------------------------------------- */ -- 2.9.2