From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933825AbcHBMDw (ORCPT ); Tue, 2 Aug 2016 08:03:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:10281 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932940AbcHBMCl (ORCPT ); Tue, 2 Aug 2016 08:02:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149305564" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, mkrufky@linuxtv.org, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, elfring@users.sourceforge.net, chuansheng.liu@intel.com, baolex.ni@intel.com, max@duempel.org Subject: [PATCH 0559/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:24:20 +0800 Message-Id: <20160802112420.19250-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/tuners/r820t.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 6ab35e3..18670c2 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c @@ -52,11 +52,11 @@ #define VER_NUM 49 static int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "enable verbose debug messages"); static int no_imr_cal; -module_param(no_imr_cal, int, 0444); +module_param(no_imr_cal, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(no_imr_cal, "Disable IMR calibration at module init"); -- 2.9.2