mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baole Ni <baolex.ni@intel.com>
To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org,
	mchehab@redhat.com, m.chehab@samsung.com, isely@pobox.com,
	hdegoede@redhat.com, kgene@kernel.org, k.kozlowski@samsung.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	chuansheng.liu@intel.com, baolex.ni@intel.com
Subject: [PATCH 0639/1285] Replace numeric parameter like 0444 with macro
Date: Tue,  2 Aug 2016 19:32:10 +0800	[thread overview]
Message-ID: <20160802113210.24639-1-baolex.ni@intel.com> (raw)

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index 83e9a3e..83c3c22 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -81,11 +81,11 @@ MODULE_PARM_DESC(init_pause_msec, "hardware initialization settling delay");
 module_param(procreload, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(procreload,
 		 "Attempt init failure recovery with firmware reload");
-module_param_array(tuner,    int, NULL, 0444);
+module_param_array(tuner,    int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(tuner,"specify installed tuner type");
-module_param_array(video_std,    int, NULL, 0444);
+module_param_array(video_std,    int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(video_std,"specify initial video standard");
-module_param_array(tolerance,    int, NULL, 0444);
+module_param_array(tolerance,    int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(tolerance,"specify stream error tolerance");
 
 /* US Broadcast channel 3 (61.25 MHz), to help with testing */
@@ -93,9 +93,9 @@ static int default_tv_freq    = 61250000L;
 /* 104.3 MHz, a usable FM station for my area */
 static int default_radio_freq = 104300000L;
 
-module_param_named(tv_freq, default_tv_freq, int, 0444);
+module_param_named(tv_freq, default_tv_freq, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(tv_freq, "specify initial television frequency");
-module_param_named(radio_freq, default_radio_freq, int, 0444);
+module_param_named(radio_freq, default_radio_freq, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(radio_freq, "specify initial radio frequency");
 
 #define PVR2_CTL_WRITE_ENDPOINT  0x01
-- 
2.9.2

                 reply	other threads:[~2016-08-02 12:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802113210.24639-1-baolex.ni@intel.com \
    --to=baolex.ni@intel.com \
    --cc=chuansheng.liu@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=isely@pobox.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=maurochehab@gmail.com \
    --cc=mchehab@infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®