From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933929AbcHBML3 (ORCPT ); Tue, 2 Aug 2016 08:11:29 -0400 Received: from mga14.intel.com ([192.55.52.115]:17298 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933780AbcHBMKD (ORCPT ); Tue, 2 Aug 2016 08:10:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858121525" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, isely@pobox.com, hdegoede@redhat.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0641/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:32:20 +0800 Message-Id: <20160802113220.24771-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c index 81f788b..d03cba4 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c @@ -73,13 +73,13 @@ struct pvr2_v4l2 { }; static int video_nr[PVR_NUM] = {[0 ... PVR_NUM-1] = -1}; -module_param_array(video_nr, int, NULL, 0444); +module_param_array(video_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(video_nr, "Offset for device's video dev minor"); static int radio_nr[PVR_NUM] = {[0 ... PVR_NUM-1] = -1}; -module_param_array(radio_nr, int, NULL, 0444); +module_param_array(radio_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(radio_nr, "Offset for device's radio dev minor"); static int vbi_nr[PVR_NUM] = {[0 ... PVR_NUM-1] = -1}; -module_param_array(vbi_nr, int, NULL, 0444); +module_param_array(vbi_nr, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vbi_nr, "Offset for device's vbi dev minor"); static struct v4l2_fmtdesc pvr_fmtdesc [] = { -- 2.9.2