From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934260AbcHBMQI (ORCPT ); Tue, 2 Aug 2016 08:16:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:54096 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933903AbcHBMP6 (ORCPT ); Tue, 2 Aug 2016 08:15:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018211701" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, ezequiel@vanguardiasur.com.ar, hdegoede@redhat.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jh1009.sung@samsung.com, nenggun.kim@samsung.com Subject: [PATCH 0646/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:32:47 +0800 Message-Id: <20160802113247.25103-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/stk1160/stk1160-v4l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c b/drivers/media/usb/stk1160/stk1160-v4l.c index 77131fd..4d0b01e 100644 --- a/drivers/media/usb/stk1160/stk1160-v4l.c +++ b/drivers/media/usb/stk1160/stk1160-v4l.c @@ -39,7 +39,7 @@ #include "stk1160-reg.h" static bool keep_buffers; -module_param(keep_buffers, bool, 0644); +module_param(keep_buffers, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(keep_buffers, "don't release buffers upon stop streaming"); enum stk1160_decimate_mode { -- 2.9.2