From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935100AbcHBQ1E (ORCPT ); Tue, 2 Aug 2016 12:27:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:55300 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934050AbcHBMMA (ORCPT ); Tue, 2 Aug 2016 08:12:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006950363" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, ezequiel@vanguardiasur.com.ar, hdegoede@redhat.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, luisbg@osg.samsung.com, hans.verkuil@cisco.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0649/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:33:04 +0800 Message-Id: <20160802113304.25305-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/tm6000/tm6000-alsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/tm6000/tm6000-alsa.c b/drivers/media/usb/tm6000/tm6000-alsa.c index e21c7aa..4b2c874 100644 --- a/drivers/media/usb/tm6000/tm6000-alsa.c +++ b/drivers/media/usb/tm6000/tm6000-alsa.c @@ -44,10 +44,10 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-MAX */ static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable tm6000x soundcard. default enabled."); -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for tm6000x capture interface(s)."); @@ -62,7 +62,7 @@ MODULE_SUPPORTED_DEVICE("{{Trident,tm5600}," "{{Trident,tm6000}," "{{Trident,tm6010}"); static unsigned int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "enable debug messages"); /**************************************************************************** -- 2.9.2