mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baole Ni <baolex.ni@intel.com>
To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org,
	mchehab@redhat.com, m.chehab@samsung.com,
	ezequiel@vanguardiasur.com.ar, hdegoede@redhat.com,
	kgene@kernel.org, k.kozlowski@samsung.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	hverkuil@xs4all.nl, arnd@arndb.de, chuansheng.liu@intel.com,
	baolex.ni@intel.com
Subject: [PATCH 0658/1285] Replace numeric parameter like 0444 with macro
Date: Tue,  2 Aug 2016 19:34:07 +0800	[thread overview]
Message-ID: <20160802113407.25918-1-baolex.ni@intel.com> (raw)

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/usb/usbvision/usbvision-core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c
index 1ea04e7..06c7194 100644
--- a/drivers/media/usb/usbvision/usbvision-core.c
+++ b/drivers/media/usb/usbvision/usbvision-core.c
@@ -46,25 +46,25 @@
 #include "usbvision.h"
 
 static unsigned int core_debug;
-module_param(core_debug, int, 0644);
+module_param(core_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(core_debug, "enable debug messages [core]");
 
 static int adjust_compression = 1;	/* Set the compression to be adaptive */
-module_param(adjust_compression, int, 0444);
+module_param(adjust_compression, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(adjust_compression, " Set the ADPCM compression for the device.  Default: 1 (On)");
 
 /* To help people with Black and White output with using s-video input.
  * Some cables and input device are wired differently. */
 static int switch_svideo_input;
-module_param(switch_svideo_input, int, 0444);
+module_param(switch_svideo_input, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(switch_svideo_input, " Set the S-Video input.  Some cables and input device are wired differently. Default: 0 (Off)");
 
 static unsigned int adjust_x_offset = -1;
-module_param(adjust_x_offset, int, 0644);
+module_param(adjust_x_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(adjust_x_offset, "adjust X offset display [core]");
 
 static unsigned int adjust_y_offset = -1;
-module_param(adjust_y_offset, int, 0644);
+module_param(adjust_y_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(adjust_y_offset, "adjust Y offset display [core]");
 
 
-- 
2.9.2

             reply	other threads:[~2016-08-02 12:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 11:34 Baole Ni [this message]
2016-08-03 19:21 ` Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802113407.25918-1-baolex.ni@intel.com \
    --to=baolex.ni@intel.com \
    --cc=arnd@arndb.de \
    --cc=chuansheng.liu@intel.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=hdegoede@redhat.com \
    --cc=hverkuil@xs4all.nl \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=maurochehab@gmail.com \
    --cc=mchehab@infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®