From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967909AbcHBQWz (ORCPT ); Tue, 2 Aug 2016 12:22:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:29882 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934064AbcHBMMD (ORCPT ); Tue, 2 Aug 2016 08:12:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018212485" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, ezequiel@vanguardiasur.com.ar, hdegoede@redhat.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, vdronov@redhat.com, geliangtang@163.com, wuninsu@gmail.com, oneukum@suse.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0660/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:34:21 +0800 Message-Id: <20160802113421.26054-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/usbvision/usbvision-video.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/usbvision/usbvision-video.c b/drivers/media/usb/usbvision/usbvision-video.c index ad2f3d2..21a0d62a 100644 --- a/drivers/media/usb/usbvision/usbvision-video.c +++ b/drivers/media/usb/usbvision/usbvision-video.c @@ -131,10 +131,10 @@ static int radio_nr = -1; /* Grab parameters for the device driver */ /* Showing parameters under SYSFS */ -module_param(isoc_mode, int, 0444); -module_param(video_debug, int, 0444); -module_param(video_nr, int, 0444); -module_param(radio_nr, int, 0444); +module_param(isoc_mode, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(video_debug, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(video_nr, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(radio_nr, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(isoc_mode, " Set the default format for ISOC endpoint. Default: 0x60 (Compression On)"); MODULE_PARM_DESC(video_debug, " Set the default Debug Mode of the device driver. Default: 0 (Off)"); -- 2.9.2