From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934233AbcHBMPn (ORCPT ); Tue, 2 Aug 2016 08:15:43 -0400 Received: from mga04.intel.com ([192.55.52.120]:32969 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933725AbcHBMMV (ORCPT ); Tue, 2 Aug 2016 08:12:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149310314" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, royale@zerezo.com, hdegoede@redhat.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0662/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:34:33 +0800 Message-Id: <20160802113433.26188-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/v4l2-core/tuner-core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c index 731487b..2d029d2 100644 --- a/drivers/media/v4l2-core/tuner-core.c +++ b/drivers/media/v4l2-core/tuner-core.c @@ -54,9 +54,9 @@ static unsigned int addr; static unsigned int no_autodetect; static unsigned int show_i2c; -module_param(addr, int, 0444); -module_param(no_autodetect, int, 0444); -module_param(show_i2c, int, 0444); +module_param(addr, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(no_autodetect, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(show_i2c, int, S_IRUSR | S_IRGRP | S_IROTH); /* insmod options used at runtime => read/write */ static int tuner_debug; @@ -66,12 +66,12 @@ static char pal[] = "--"; static char secam[] = "--"; static char ntsc[] = "-"; -module_param_named(debug, tuner_debug, int, 0644); -module_param_array(tv_range, int, NULL, 0644); -module_param_array(radio_range, int, NULL, 0644); -module_param_string(pal, pal, sizeof(pal), 0644); -module_param_string(secam, secam, sizeof(secam), 0644); -module_param_string(ntsc, ntsc, sizeof(ntsc), 0644); +module_param_named(debug, tuner_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_array(tv_range, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_array(radio_range, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_string(pal, pal, sizeof(pal), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_string(secam, secam, sizeof(secam), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_string(ntsc, ntsc, sizeof(ntsc), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* * Static vars -- 2.9.2