From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967526AbcHBPov (ORCPT ); Tue, 2 Aug 2016 11:44:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:1997 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934539AbcHBMWr (ORCPT ); Tue, 2 Aug 2016 08:22:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033589080" From: Baole Ni To: arnd@arndb.de, gregkh@linuxfoundation.org, suganath-prabu.subramani@broadcom.com, mchehab@redhat.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jkosina@suse.cz, geliangtang@163.com Subject: [PATCH 0682/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:36:26 +0800 Message-Id: <20160802113626.27532-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/misc/cs5535-mfgpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cs5535-mfgpt.c b/drivers/misc/cs5535-mfgpt.c index 347f08f..e91c6c2 100644 --- a/drivers/misc/cs5535-mfgpt.c +++ b/drivers/misc/cs5535-mfgpt.c @@ -23,7 +23,7 @@ #define DRV_NAME "cs5535-mfgpt" static int mfgpt_reset_timers; -module_param_named(mfgptfix, mfgpt_reset_timers, int, 0644); +module_param_named(mfgptfix, mfgpt_reset_timers, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(mfgptfix, "Try to reset the MFGPT timers during init; " "required by some broken BIOSes (ie, TinyBIOS < 0.99) or kexec " "(1 = reset the MFGPT using an undocumented bit, " -- 2.9.2