From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966966AbcHBPwZ (ORCPT ); Tue, 2 Aug 2016 11:52:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:39462 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934708AbcHBMWX (ORCPT ); Tue, 2 Aug 2016 08:22:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743082426" From: Baole Ni To: eric.piel@tremplin-utc.net, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@redhat.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, geliangtang@163.com Subject: [PATCH 0687/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:36:48 +0800 Message-Id: <20160802113648.27862-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/misc/lis3lv02d/lis3lv02d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c index fb8705f..07e8fca 100644 --- a/drivers/misc/lis3lv02d/lis3lv02d.c +++ b/drivers/misc/lis3lv02d/lis3lv02d.c @@ -122,7 +122,7 @@ static const struct kernel_param_ops param_ops_axis = { #define param_check_axis(name, p) param_check_int(name, p) -module_param_array_named(axes, lis3_dev.ac.as_array, axis, NULL, 0644); +module_param_array_named(axes, lis3_dev.ac.as_array, axis, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(axes, "Axis-mapping for x,y,z directions"); static s16 lis3lv02d_read_8(struct lis3lv02d *lis3, int reg) -- 2.9.2