From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935350AbcHBQPb (ORCPT ); Tue, 2 Aug 2016 12:15:31 -0400 Received: from mga04.intel.com ([192.55.52.120]:51141 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934298AbcHBMRh (ORCPT ); Tue, 2 Aug 2016 08:17:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018214960" From: Baole Ni To: leedom@chelsio.com, rric@kernel.org, felix.manlunas@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com, computersforpeace@gmail.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, mugunthanvnm@ti.com, marcel@ziswiler.com, felipe.balbi@linux.intel.com, fw@strlen.de, harvey.hunt@imgtec.com, robert.jarzmik@free.fr, Baohua.Song@csr.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0716/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:39:23 +0800 Message-Id: <20160802113923.29795-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/ethernet/davicom/dm9000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 1471e16..0680085 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -57,14 +57,14 @@ * Transmit timeout, default 5 seconds. */ static int watchdog = 5000; -module_param(watchdog, int, 0400); +module_param(watchdog, int, S_IRUSR); MODULE_PARM_DESC(watchdog, "transmit timeout in milliseconds"); /* * Debug messages level */ static int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "dm9000 debug level (0-4)"); /* DM9000 register address locking. -- 2.9.2