From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964789AbcHBMVo (ORCPT ); Tue, 2 Aug 2016 08:21:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:8273 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934541AbcHBMUX (ORCPT ); Tue, 2 Aug 2016 08:20:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018216719" From: Baole Ni To: richardcochran@gmail.com, f.fainelli@gmail.com, bkenward@solarflare.com, linux-driver@qlogic.com, computersforpeace@gmail.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, mst@redhat.com, pabeni@redhat.com, jasowang@redhat.com, makita.toshiaki@lab.ntt.co.jp, hannes@stressinduktion.org, daniel@iogearbox.net, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0750/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:42:41 +0800 Message-Id: <20160802114241.32062-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/tun.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index e16487c..23bca00 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1673,9 +1673,9 @@ static ssize_t tun_show_group(struct device *dev, struct device_attribute *attr, sprintf(buf, "-1\n"); } -static DEVICE_ATTR(tun_flags, 0444, tun_show_flags, NULL); -static DEVICE_ATTR(owner, 0444, tun_show_owner, NULL); -static DEVICE_ATTR(group, 0444, tun_show_group, NULL); +static DEVICE_ATTR(tun_flags, S_IRUSR | S_IRGRP | S_IROTH, tun_show_flags, NULL); +static DEVICE_ATTR(owner, S_IRUSR | S_IRGRP | S_IROTH, tun_show_owner, NULL); +static DEVICE_ATTR(group, S_IRUSR | S_IRGRP | S_IROTH, tun_show_group, NULL); static struct attribute *tun_dev_attrs[] = { &dev_attr_tun_flags.attr, -- 2.9.2