From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967484AbcHBPzX (ORCPT ); Tue, 2 Aug 2016 11:55:23 -0400 Received: from mga09.intel.com ([134.134.136.24]:52014 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934574AbcHBMUn (ORCPT ); Tue, 2 Aug 2016 08:20:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033592013" From: Baole Ni To: steve.glendinning@shawell.net, f.fainelli@gmail.com, bkenward@solarflare.com, linux-driver@qlogic.com, computersforpeace@gmail.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, pabeni@redhat.com, jasowang@redhat.com, makita.toshiaki@lab.ntt.co.jp, hannes@stressinduktion.org, daniel@iogearbox.net Subject: [PATCH 0751/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:42:46 +0800 Message-Id: <20160802114246.32129-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/usb/smsc75xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index 9af9799..d384afe 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c @@ -79,7 +79,7 @@ struct usb_context { }; static bool turbo_mode = true; -module_param(turbo_mode, bool, 0644); +module_param(turbo_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(turbo_mode, "Enable multiple frames per Rx transaction"); static int __must_check __smsc75xx_read_reg(struct usbnet *dev, u32 index, -- 2.9.2