From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964871AbcHBM1P (ORCPT ); Tue, 2 Aug 2016 08:27:15 -0400 Received: from mga02.intel.com ([134.134.136.20]:39560 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934505AbcHBM0j (ORCPT ); Tue, 2 Aug 2016 08:26:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018219821" From: Baole Ni To: boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, linuxwifi@intel.com, kvalo@codeaurora.org, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0806/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:48:17 +0800 Message-Id: <20160802114817.3699-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/xen-netfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 96ccd4e..70c86fa 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -58,7 +58,7 @@ /* Module parameters */ static unsigned int xennet_max_queues; -module_param_named(max_queues, xennet_max_queues, uint, 0644); +module_param_named(max_queues, xennet_max_queues, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_queues, "Maximum number of queues per virtual interface"); -- 2.9.2