From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964984AbcHBMaS (ORCPT ); Tue, 2 Aug 2016 08:30:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:2412 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934932AbcHBM3A (ORCPT ); Tue, 2 Aug 2016 08:29:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743087567" From: Baole Ni To: konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0836/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:51:12 +0800 Message-Id: <20160802115112.5724-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/pcmcia/tcic.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pcmcia/tcic.c b/drivers/pcmcia/tcic.c index 1ee63e5..eb000d8 100644 --- a/drivers/pcmcia/tcic.c +++ b/drivers/pcmcia/tcic.c @@ -85,15 +85,15 @@ static int poll_quick = HZ/20; /* CCLK external clock time, in nanoseconds. 70 ns = 14.31818 MHz */ static int cycle_time = 70; -module_param(tcic_base, ulong, 0444); -module_param(ignore, int, 0444); -module_param(do_scan, int, 0444); -module_param(irq_mask, int, 0444); -module_param_array(irq_list, int, &irq_list_count, 0444); -module_param(cs_irq, int, 0444); -module_param(poll_interval, int, 0444); -module_param(poll_quick, int, 0444); -module_param(cycle_time, int, 0444); +module_param(tcic_base, ulong, S_IRUSR | S_IRGRP | S_IROTH); +module_param(ignore, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(do_scan, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(irq_mask, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param_array(irq_list, int, &irq_list_count, S_IRUSR | S_IRGRP | S_IROTH); +module_param(cs_irq, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(poll_interval, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(poll_quick, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(cycle_time, int, S_IRUSR | S_IRGRP | S_IROTH); /*====================================================================*/ -- 2.9.2