From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967013AbcHBPa3 (ORCPT ); Tue, 2 Aug 2016 11:30:29 -0400 Received: from mga03.intel.com ([134.134.136.65]:17085 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934948AbcHBM3R (ORCPT ); Tue, 2 Aug 2016 08:29:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743087669" From: Baole Ni To: kishon@ti.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0839/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:51:27 +0800 Message-Id: <20160802115127.5926-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/phy/phy-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-xgene.c b/drivers/phy/phy-xgene.c index 385362e..f934d7f 100644 --- a/drivers/phy/phy-xgene.c +++ b/drivers/phy/phy-xgene.c @@ -557,7 +557,7 @@ struct xgene_phy_ctx { */ static int preA3Chip; MODULE_PARM_DESC(preA3Chip, "Enable pre-A3 chip support (1=enable 0=disable)"); -module_param_named(preA3Chip, preA3Chip, int, 0444); +module_param_named(preA3Chip, preA3Chip, int, S_IRUSR | S_IRGRP | S_IROTH); static void sds_wr(void __iomem *csr_base, u32 indirect_cmd_reg, u32 indirect_data_reg, u32 addr, u32 data) -- 2.9.2