From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966180AbcHBPTd (ORCPT ); Tue, 2 Aug 2016 11:19:33 -0400 Received: from mga03.intel.com ([134.134.136.65]:53573 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965010AbcHBMet (ORCPT ); Tue, 2 Aug 2016 08:34:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858135098" From: Baole Ni To: cezary.jackiewicz@gmail.com, dvhart@infradead.org, david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0846/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:51:59 +0800 Message-Id: <20160802115159.6390-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/platform/x86/compal-laptop.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c index e1c2b6d..eaa3ecb 100644 --- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c @@ -680,17 +680,17 @@ static int bat_writeable_property(struct power_supply *psy, /* Driver Globals */ /* ============== */ static DEVICE_ATTR(wake_up_pme, - 0644, wake_up_pme_show, wake_up_pme_store); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, wake_up_pme_show, wake_up_pme_store); static DEVICE_ATTR(wake_up_modem, - 0644, wake_up_modem_show, wake_up_modem_store); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, wake_up_modem_show, wake_up_modem_store); static DEVICE_ATTR(wake_up_lan, - 0644, wake_up_lan_show, wake_up_lan_store); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, wake_up_lan_show, wake_up_lan_store); static DEVICE_ATTR(wake_up_wlan, - 0644, wake_up_wlan_show, wake_up_wlan_store); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, wake_up_wlan_show, wake_up_wlan_store); static DEVICE_ATTR(wake_up_key, - 0644, wake_up_key_show, wake_up_key_store); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, wake_up_key_show, wake_up_key_store); static DEVICE_ATTR(wake_up_mouse, - 0644, wake_up_mouse_show, wake_up_mouse_store); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, wake_up_mouse_show, wake_up_mouse_store); static DEVICE_ATTR(fan1_input, S_IRUGO, fan_show, NULL); static DEVICE_ATTR(temp1_input, S_IRUGO, temp_cpu, NULL); -- 2.9.2