From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935125AbcHBMky (ORCPT ); Tue, 2 Aug 2016 08:40:54 -0400 Received: from mga04.intel.com ([192.55.52.120]:18067 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935147AbcHBMjQ (ORCPT ); Tue, 2 Aug 2016 08:39:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149319912" From: Baole Ni To: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, dwmw2@infradead.org, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, ursula.braun@de.ibm.com, joe@perches.com, peter.senna@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0877/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:54:26 +0800 Message-Id: <20160802115426.8444-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/s390/char/monreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/char/monreader.c b/drivers/s390/char/monreader.c index ebdeaa5..54a0c5e 100644 --- a/drivers/s390/char/monreader.c +++ b/drivers/s390/char/monreader.c @@ -641,7 +641,7 @@ static void __exit mon_exit(void) module_init(mon_init); module_exit(mon_exit); -module_param_string(mondcss, mon_dcss_name, 9, 0444); +module_param_string(mondcss, mon_dcss_name, 9, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(mondcss, "Name of DCSS segment to be used for *MONITOR " "service, max. 8 chars. Default is MONDCSS"); -- 2.9.2