From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756839AbcHBPNy (ORCPT ); Tue, 2 Aug 2016 11:13:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:47556 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965077AbcHBMe4 (ORCPT ); Tue, 2 Aug 2016 08:34:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028280820" From: Baole Ni To: ubraun@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, dwmw2@infradead.org, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0898/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:56:15 +0800 Message-Id: <20160802115615.9841-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/s390/net/smsgiucv_app.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/net/smsgiucv_app.c b/drivers/s390/net/smsgiucv_app.c index 32515a2..15d4075 100644 --- a/drivers/s390/net/smsgiucv_app.c +++ b/drivers/s390/net/smsgiucv_app.c @@ -40,7 +40,7 @@ * If the value is undefined or empty (""), special messages are * accepted from any z/VM user ID. */ static char *sender; -module_param(sender, charp, 0400); +module_param(sender, charp, S_IRUSR); MODULE_PARM_DESC(sender, "z/VM user ID from which CP SMSGs are accepted"); /* SMSG device representation */ -- 2.9.2