From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966317AbcHBO4Q (ORCPT ); Tue, 2 Aug 2016 10:56:16 -0400 Received: from mga09.intel.com ([134.134.136.24]:59231 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935045AbcHBMik (ORCPT ); Tue, 2 Aug 2016 08:38:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033600442" From: Baole Ni To: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, jsimmons@infradead.org, Keith.Mannthey@intel.com, mike.rapoport@gmail.com, bruce.korb@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0937/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:00:11 +0800 Message-Id: <20160802120011.12483-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c index ab739f0..8d95385 100644 --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c @@ -48,11 +48,11 @@ #include "ldlm_internal.h" static int ldlm_num_threads; -module_param(ldlm_num_threads, int, 0444); +module_param(ldlm_num_threads, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ldlm_num_threads, "number of DLM service threads to start"); static char *ldlm_cpts; -module_param(ldlm_cpts, charp, 0444); +module_param(ldlm_cpts, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ldlm_cpts, "CPU partitions ldlm threads should run on"); static struct mutex ldlm_ref_mutex; -- 2.9.2