From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966161AbcHBOzS (ORCPT ); Tue, 2 Aug 2016 10:55:18 -0400 Received: from mga03.intel.com ([134.134.136.65]:40962 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934533AbcHBMil (ORCPT ); Tue, 2 Aug 2016 08:38:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028282740" From: Baole Ni To: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, fzago@cray.com, john.hammond@intel.com, jsimmons@infradead.org, mike.rapoport@gmail.com, axboe@fb.com, kirill.shutemov@linux.intel.com, viro@zeniv.linux.org.uk, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0939/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:00:26 +0800 Message-Id: <20160802120026.12621-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/staging/lustre/lustre/llite/lloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/staging/lustre/lustre/llite/lloop.c index 813a9a3..5f751e4 100644 --- a/drivers/staging/lustre/lustre/llite/lloop.c +++ b/drivers/staging/lustre/lustre/llite/lloop.c @@ -872,7 +872,7 @@ static void lloop_exit(void) kfree(loop_dev); } -module_param(max_loop, int, 0444); +module_param(max_loop, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_loop, "maximum of lloop_device"); MODULE_AUTHOR("OpenSFS, Inc. "); MODULE_DESCRIPTION("Lustre virtual block device"); -- 2.9.2