From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966911AbcHBNuj (ORCPT ); Tue, 2 Aug 2016 09:50:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:3247 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966680AbcHBNud (ORCPT ); Tue, 2 Aug 2016 09:50:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858143162" From: Baole Ni To: gregkh@linuxfoundation.org, Jes.Sorensen@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, mugunthanvnm@ti.com, felipe.balbi@linux.intel.com, a@unstable.cc, fw@strlen.de, bankarsandhya512@gmail.com, fuyong@linux.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0956/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:02:35 +0800 Message-Id: <20160802120235.13786-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/staging/wlan-ng/p80211netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c index 90cc8cd..d6f567d 100644 --- a/drivers/staging/wlan-ng/p80211netdev.c +++ b/drivers/staging/wlan-ng/p80211netdev.c @@ -104,11 +104,11 @@ static void p80211knetdev_tx_timeout(netdevice_t *netdev); static int p80211_rx_typedrop(wlandevice_t *wlandev, u16 fc); int wlan_watchdog = 5000; -module_param(wlan_watchdog, int, 0644); +module_param(wlan_watchdog, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(wlan_watchdog, "transmit timeout in milliseconds"); int wlan_wext_write = 1; -module_param(wlan_wext_write, int, 0644); +module_param(wlan_wext_write, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(wlan_wext_write, "enable write wireless extensions"); /*---------------------------------------------------------------- -- 2.9.2