From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966283AbcHBNEb (ORCPT ); Tue, 2 Aug 2016 09:04:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:60547 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935176AbcHBNCx (ORCPT ); Tue, 2 Aug 2016 09:02:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006965420" From: Baole Ni To: gregkh@linuxfoundation.org, Jes.Sorensen@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, ciorneiioana@gmail.com, amitoj1606@gmail.com, maciek.borzecki@gmail.com, janani.rvchndrn@gmail.com, bankarsandhya512@gmail.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0957/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:02:42 +0800 Message-Id: <20160802120242.13856-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/staging/wlan-ng/prism2sta.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 64f9072..eff5f6b 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -88,12 +88,12 @@ int prism2_reset_settletime = 100; /* Reset settle time in ms */ static int prism2_doreset; /* Do a reset at init? */ -module_param(prism2_doreset, int, 0644); +module_param(prism2_doreset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(prism2_doreset, "Issue a reset on initialization"); -module_param(prism2_reset_holdtime, int, 0644); +module_param(prism2_reset_holdtime, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(prism2_reset_holdtime, "reset hold time in ms"); -module_param(prism2_reset_settletime, int, 0644); +module_param(prism2_reset_settletime, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(prism2_reset_settletime, "reset settle time in ms"); MODULE_LICENSE("Dual MPL/GPL"); -- 2.9.2