From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965629AbcHBOtB (ORCPT ); Tue, 2 Aug 2016 10:49:01 -0400 Received: from mga14.intel.com ([192.55.52.115]:39817 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934938AbcHBMnB (ORCPT ); Tue, 2 Aug 2016 08:43:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858144460" From: Baole Ni To: gregkh@linuxfoundation.org, stf_xl@wp.pl, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, kborer@gmail.com, michele.curti@gmail.com, rpathak@visteon.com, sesse@google.com, reillyg@chromium.org, viro@zeniv.linux.org.uk, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0975/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:04:20 +0800 Message-Id: <20160802120420.15064-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index e9f5043..fb3c152 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -135,7 +135,7 @@ enum snoop_when { /* Limit on the total amount of memory we can allocate for transfers */ static unsigned usbfs_memory_mb = 16; -module_param(usbfs_memory_mb, uint, 0644); +module_param(usbfs_memory_mb, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(usbfs_memory_mb, "maximum MB allowed for usbfs buffers (0 = no limit)"); -- 2.9.2