From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965569AbcHBOsX (ORCPT ); Tue, 2 Aug 2016 10:48:23 -0400 Received: from mga09.intel.com ([134.134.136.24]:59213 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934773AbcHBMnB (ORCPT ); Tue, 2 Aug 2016 08:43:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743093339" From: Baole Ni To: balbi@kernel.org, gregkh@linuxfoundation.org, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, k.opasiak@samsung.com, i.kotrasinsk@samsung.com, chuansheng.liu@intel.com, baolex.ni@intel.com, johan@kernel.org, hkallweit1@gmail.com, tomeu.vizoso@collabora.com, nicstange@gmail.com, oneukum@suse.com Subject: [PATCH 0977/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:04:35 +0800 Message-Id: <20160802120435.15200-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/usb/gadget/legacy/g_ffs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/legacy/g_ffs.c b/drivers/usb/gadget/legacy/g_ffs.c index f85639e..79f931c 100644 --- a/drivers/usb/gadget/legacy/g_ffs.c +++ b/drivers/usb/gadget/legacy/g_ffs.c @@ -79,11 +79,11 @@ static struct usb_device_descriptor gfs_dev_desc = { static char *func_names[GFS_MAX_DEVS]; static unsigned int func_num; -module_param_named(bDeviceClass, gfs_dev_desc.bDeviceClass, byte, 0644); +module_param_named(bDeviceClass, gfs_dev_desc.bDeviceClass, byte, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bDeviceClass, "USB Device class"); -module_param_named(bDeviceSubClass, gfs_dev_desc.bDeviceSubClass, byte, 0644); +module_param_named(bDeviceSubClass, gfs_dev_desc.bDeviceSubClass, byte, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bDeviceSubClass, "USB Device subclass"); -module_param_named(bDeviceProtocol, gfs_dev_desc.bDeviceProtocol, byte, 0644); +module_param_named(bDeviceProtocol, gfs_dev_desc.bDeviceProtocol, byte, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bDeviceProtocol, "USB Device protocol"); module_param_array_named(functions, func_names, charp, &func_num, 0); MODULE_PARM_DESC(functions, "USB Functions list"); -- 2.9.2