From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935184AbcHBOpl (ORCPT ); Tue, 2 Aug 2016 10:45:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:26038 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935122AbcHBMnF (ORCPT ); Tue, 2 Aug 2016 08:43:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006966516" From: Baole Ni To: balbi@kernel.org, gregkh@linuxfoundation.org, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, r.baldyga@samsung.com, heikki.krogerus@linux.intel.com, yousaf.kaukab@intel.com, chuansheng.liu@intel.com, baolex.ni@intel.com, nicstange@gmail.com, oneukum@suse.com Subject: [PATCH 0980/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:04:56 +0800 Message-Id: <20160802120456.15405-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/usb/gadget/udc/net2280.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c index c894b94..58a741f 100644 --- a/drivers/usb/gadget/udc/net2280.c +++ b/drivers/usb/gadget/udc/net2280.c @@ -133,7 +133,7 @@ static const struct { static ushort fifo_mode; /* "modprobe net2280 fifo_mode=1" etc */ -module_param(fifo_mode, ushort, 0644); +module_param(fifo_mode, ushort, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* enable_suspend -- When enabled, the driver will respond to * USB suspend requests by powering down the NET2280. Otherwise, @@ -143,7 +143,7 @@ module_param(fifo_mode, ushort, 0644); static bool enable_suspend; /* "modprobe net2280 enable_suspend=1" etc */ -module_param(enable_suspend, bool, 0444); +module_param(enable_suspend, bool, S_IRUSR | S_IRGRP | S_IROTH); #define DIR_STRING(bAddress) (((bAddress) & USB_DIR_IN) ? "in" : "out") -- 2.9.2