From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965427AbcHBMsY (ORCPT ); Tue, 2 Aug 2016 08:48:24 -0400 Received: from mga09.intel.com ([134.134.136.24]:34886 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965330AbcHBMpv (ORCPT ); Tue, 2 Aug 2016 08:45:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149326325" From: Baole Ni To: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com, bp@suse.de, mcgrof@suse.com, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: [PATCH 1009/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:07:53 +0800 Message-Id: <20160802120753.17355-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/video/fbdev/i740fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index cf5ccd0..5cc240c 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -1301,8 +1301,8 @@ MODULE_AUTHOR("(c) 2011 Ondrej Zary "); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("fbdev driver for Intel740"); -module_param(mode_option, charp, 0444); +module_param(mode_option, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(mode_option, "Default video mode ('640x480-8@60', etc)"); -module_param(mtrr, int, 0444); +module_param(mtrr, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(mtrr, "Enable write-combining with MTRR (1=enable, 0=disable, default=1)"); -- 2.9.2