From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965331AbcHBO0z (ORCPT ); Tue, 2 Aug 2016 10:26:55 -0400 Received: from mga02.intel.com ([134.134.136.20]:43354 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965554AbcHBMwb (ORCPT ); Tue, 2 Aug 2016 08:52:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006968619" From: Baole Ni To: zbr@ioremap.net, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, manio@skyboo.net, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: [PATCH 1025/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:09:31 +0800 Message-Id: <20160802120931.18443-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/w1/masters/ds2482.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 2e30db1..63b346f 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -34,7 +34,7 @@ * only a single slave on the 1-Wire line. */ static int ds2482_active_pullup = 1; -module_param_named(active_pullup, ds2482_active_pullup, int, 0644); +module_param_named(active_pullup, ds2482_active_pullup, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /** * The DS2482 registers - there are 3 registers that are addressed by a read -- 2.9.2