From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965754AbcHBMy6 (ORCPT ); Tue, 2 Aug 2016 08:54:58 -0400 Received: from mga04.intel.com ([192.55.52.120]:61668 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965085AbcHBMx5 (ORCPT ); Tue, 2 Aug 2016 08:53:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018231832" From: Baole Ni To: boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: [PATCH 1031/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:10:00 +0800 Message-Id: <20160802121000.18840-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/xen/xen-balloon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/xen/xen-balloon.c b/drivers/xen/xen-balloon.c index 79865b8..0a8cad2 100644 --- a/drivers/xen/xen-balloon.c +++ b/drivers/xen/xen-balloon.c @@ -124,10 +124,10 @@ BALLOON_SHOW(current_kb, "%lu\n", PAGES2KB(balloon_stats.current_pages)); BALLOON_SHOW(low_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_low)); BALLOON_SHOW(high_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_high)); -static DEVICE_ULONG_ATTR(schedule_delay, 0444, balloon_stats.schedule_delay); -static DEVICE_ULONG_ATTR(max_schedule_delay, 0644, balloon_stats.max_schedule_delay); -static DEVICE_ULONG_ATTR(retry_count, 0444, balloon_stats.retry_count); -static DEVICE_ULONG_ATTR(max_retry_count, 0644, balloon_stats.max_retry_count); +static DEVICE_ULONG_ATTR(schedule_delay, S_IRUSR | S_IRGRP | S_IROTH, balloon_stats.schedule_delay); +static DEVICE_ULONG_ATTR(max_schedule_delay, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, balloon_stats.max_schedule_delay); +static DEVICE_ULONG_ATTR(retry_count, S_IRUSR | S_IRGRP | S_IROTH, balloon_stats.retry_count); +static DEVICE_ULONG_ATTR(max_retry_count, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, balloon_stats.max_retry_count); static ssize_t show_target_kb(struct device *dev, struct device_attribute *attr, char *buf) -- 2.9.2