From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965537AbcHBMwY (ORCPT ); Tue, 2 Aug 2016 08:52:24 -0400 Received: from mga11.intel.com ([192.55.52.93]:64915 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965486AbcHBMwF (ORCPT ); Tue, 2 Aug 2016 08:52:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149327144" From: Baole Ni To: jgross@suse.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, paul.gortmaker@windriver.com, oneukum@suse.com Subject: [PATCH 1035/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:10:27 +0800 Message-Id: <20160802121027.19110-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/xen/xen-scsiback.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index d6950e0..a9fd45a 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -185,10 +185,10 @@ struct scsiback_tpg { #define SCSIBACK_INVALID_HANDLE (~0) static bool log_print_stat; -module_param(log_print_stat, bool, 0644); +module_param(log_print_stat, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int scsiback_max_buffer_pages = 1024; -module_param_named(max_buffer_pages, scsiback_max_buffer_pages, int, 0644); +module_param_named(max_buffer_pages, scsiback_max_buffer_pages, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_buffer_pages, "Maximum number of free pages to keep in backend buffer"); -- 2.9.2