From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965932AbcHBM57 (ORCPT ); Tue, 2 Aug 2016 08:57:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:47480 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965735AbcHBM5s (ORCPT ); Tue, 2 Aug 2016 08:57:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028287588" From: Baole Ni To: sfrench@samba.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, jaegeuk@kernel.org, ildarm@google.com, tytso@mit.edu, mhalcrow@google.com, kirill.shutemov@linux.intel.com, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: [PATCH 1037/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:10:42 +0800 Message-Id: <20160802121042.19247-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- fs/crypto/crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c index 2fc8c43..821098d 100644 --- a/fs/crypto/crypto.c +++ b/fs/crypto/crypto.c @@ -33,10 +33,10 @@ static unsigned int num_prealloc_crypto_pages = 32; static unsigned int num_prealloc_crypto_ctxs = 128; -module_param(num_prealloc_crypto_pages, uint, 0444); +module_param(num_prealloc_crypto_pages, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(num_prealloc_crypto_pages, "Number of crypto pages to preallocate"); -module_param(num_prealloc_crypto_ctxs, uint, 0444); +module_param(num_prealloc_crypto_ctxs, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(num_prealloc_crypto_ctxs, "Number of crypto contexts to preallocate"); -- 2.9.2