From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965592AbcHBMwv (ORCPT ); Tue, 2 Aug 2016 08:52:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:48656 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965487AbcHBMwF (ORCPT ); Tue, 2 Aug 2016 08:52:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018232311" From: Baole Ni To: miklos@szeredi.hu, adilger.kernel@dilger.ca, david.vrabel@citrix.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, mhalcrow@google.com, kirill.shutemov@linux.intel.com, oneukum@suse.com Subject: [PATCH 1042/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:11:07 +0800 Message-Id: <20160802121107.19579-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- fs/fuse/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 1ce6766..da16107 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -33,7 +33,7 @@ static int set_global_limit(const char *val, struct kernel_param *kp); unsigned max_user_bgreq; module_param_call(max_user_bgreq, set_global_limit, param_get_uint, - &max_user_bgreq, 0644); + &max_user_bgreq, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); __MODULE_PARM_TYPE(max_user_bgreq, "uint"); MODULE_PARM_DESC(max_user_bgreq, "Global limit for the maximum number of backgrounded requests an " @@ -41,7 +41,7 @@ MODULE_PARM_DESC(max_user_bgreq, unsigned max_user_congthresh; module_param_call(max_user_congthresh, set_global_limit, param_get_uint, - &max_user_congthresh, 0644); + &max_user_congthresh, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); __MODULE_PARM_TYPE(max_user_congthresh, "uint"); MODULE_PARM_DESC(max_user_congthresh, "Global limit for the maximum congestion threshold an " -- 2.9.2