From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934545AbcHBOb3 (ORCPT ); Tue, 2 Aug 2016 10:31:29 -0400 Received: from mga02.intel.com ([134.134.136.20]:28512 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965510AbcHBMwM (ORCPT ); Tue, 2 Aug 2016 08:52:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028288488" From: Baole Ni To: anton@enomsg.org, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kirill.shutemov@linux.intel.com, vdavydov@virtuozzo.com, oneukum@suse.com Subject: [PATCH 1058/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:12:35 +0800 Message-Id: <20160802121235.20644-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- fs/pstore/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 588461b..1d230d6 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -45,7 +45,7 @@ * to let someone see the entry */ static int pstore_update_ms = -1; -module_param_named(update_ms, pstore_update_ms, int, 0600); +module_param_named(update_ms, pstore_update_ms, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(update_ms, "milliseconds before pstore updates its content " "(default is -1, which means runtime updates are disabled; " "enabling this option is not safe, it may lead to further " @@ -590,5 +590,5 @@ static void pstore_timefunc(unsigned long dummy) mod_timer(&pstore_timer, jiffies + msecs_to_jiffies(pstore_update_ms)); } -module_param(backend, charp, 0444); +module_param(backend, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(backend, "Pstore backend to use"); -- 2.9.2