From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770AbcHBOaJ (ORCPT ); Tue, 2 Aug 2016 10:30:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:43354 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965425AbcHBMwU (ORCPT ); Tue, 2 Aug 2016 08:52:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743096542" From: Baole Ni To: anton@enomsg.org, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, yang.shi@linaro.org, mingo@kernel.org, prarit@redhat.com, linux@rasmusvillemoes.dk, aryabinin@virtuozzo.com, baiyaowei@cmss.chinamobile.com, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 1060/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:12:47 +0800 Message-Id: <20160802121247.20778-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index 4c17fda..7d9e25d 100644 --- a/init/main.c +++ b/init/main.c @@ -674,7 +674,7 @@ static void __init do_ctors(void) } bool initcall_debug; -core_param(initcall_debug, initcall_debug, bool, 0644); +core_param(initcall_debug, initcall_debug, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #ifdef CONFIG_KALLSYMS struct blacklist_entry { -- 2.9.2