From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965774AbcHBMzM (ORCPT ); Tue, 2 Aug 2016 08:55:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:55869 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965700AbcHBMyB (ORCPT ); Tue, 2 Aug 2016 08:54:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033606950" From: Baole Ni To: tglx@linutronix.de, ccross@android.com, keescook@chromium.org, tony.luck@intel.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, rusty@rustcorp.com.au, jkosina@suse.cz Subject: [PATCH 1064/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:13:10 +0800 Message-Id: <20160802121310.21057-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- kernel/irq/spurious.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index 5707f97..718f551 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c @@ -437,7 +437,7 @@ int noirqdebug_setup(char *str) } __setup("noirqdebug", noirqdebug_setup); -module_param(noirqdebug, bool, 0644); +module_param(noirqdebug, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(noirqdebug, "Disable irq lockup detection when true"); static int __init irqfixup_setup(char *str) @@ -450,7 +450,7 @@ static int __init irqfixup_setup(char *str) } __setup("irqfixup", irqfixup_setup); -module_param(irqfixup, int, 0644); +module_param(irqfixup, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int __init irqpoll_setup(char *str) { -- 2.9.2