From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756651AbcHBO3A (ORCPT ); Tue, 2 Aug 2016 10:29:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:36131 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965486AbcHBMwZ (ORCPT ); Tue, 2 Aug 2016 08:52:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018233353" From: Baole Ni To: peterz@infradead.org, mingo@redhat.com, keescook@chromium.org, tony.luck@intel.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, rusty@rustcorp.com.au, jkosina@suse.cz Subject: [PATCH 1066/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:13:20 +0800 Message-Id: <20160802121320.21189-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- kernel/locking/locktorture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c index f8c5af5..265030a 100644 --- a/kernel/locking/locktorture.c +++ b/kernel/locking/locktorture.c @@ -59,7 +59,7 @@ torture_param(bool, verbose, true, "Enable verbose debugging printk()s"); static char *torture_type = "spin_lock"; -module_param(torture_type, charp, 0444); +module_param(torture_type, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(torture_type, "Type of lock to torture (spin_lock, spin_lock_irq, mutex_lock, ...)"); @@ -76,7 +76,7 @@ struct lock_stress_stats { }; int torture_runnable = IS_ENABLED(MODULE); -module_param(torture_runnable, int, 0444); +module_param(torture_runnable, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(torture_runnable, "Start locktorture at module init"); /* Forward reference. */ -- 2.9.2