From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756741AbcHBOaB (ORCPT ); Tue, 2 Aug 2016 10:30:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:64044 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965527AbcHBMwU (ORCPT ); Tue, 2 Aug 2016 08:52:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743096756" From: Baole Ni To: rusty@rustcorp.com.au, mingo@redhat.com, keescook@chromium.org, tony.luck@intel.com, tomi.valkeinen@ti.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, jkosina@suse.cz Subject: [PATCH 1067/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:13:26 +0800 Message-Id: <20160802121326.21255-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index 5f71aa6..58ddf54 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -271,7 +271,7 @@ static void module_assert_mutex_or_preempt(void) static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE); #ifndef CONFIG_MODULE_SIG_FORCE -module_param(sig_enforce, bool_enable_only, 0644); +module_param(sig_enforce, bool_enable_only, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #endif /* !CONFIG_MODULE_SIG_FORCE */ /* Block module loading/unloading? */ -- 2.9.2