From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935193AbcHBObh (ORCPT ); Tue, 2 Aug 2016 10:31:37 -0400 Received: from mga03.intel.com ([134.134.136.65]:62268 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965509AbcHBMwL (ORCPT ); Tue, 2 Aug 2016 08:52:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1028288833" From: Baole Ni To: paulmck@linux.vnet.ibm.com, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, mhocko@suse.com, tglx@linutronix.de, vkuznets@redhat.com, pmladek@suse.com, tj@kernel.org, jpoimboe@redhat.com Subject: [PATCH 1070/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:13:43 +0800 Message-Id: <20160802121343.21455-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- kernel/rcu/rcuperf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c index 3cee0d8..3812e93 100644 --- a/kernel/rcu/rcuperf.c +++ b/kernel/rcu/rcuperf.c @@ -66,7 +66,7 @@ torture_param(bool, shutdown, false, "Shutdown at end of performance tests."); torture_param(bool, verbose, true, "Enable verbose debugging printk()s"); static char *perf_type = "rcu"; -module_param(perf_type, charp, 0444); +module_param(perf_type, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)"); static int nrealreaders; @@ -102,7 +102,7 @@ static int rcu_perf_writer_state; #define RCUPERF_RUNNABLE_INIT 0 #endif static int perf_runnable = RCUPERF_RUNNABLE_INIT; -module_param(perf_runnable, int, 0444); +module_param(perf_runnable, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(perf_runnable, "Start rcuperf at boot"); /* -- 2.9.2