From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933626AbcHBOeF (ORCPT ); Tue, 2 Aug 2016 10:34:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:23264 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965441AbcHBMwK (ORCPT ); Tue, 2 Aug 2016 08:52:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149328630" From: Baole Ni To: john.stultz@linaro.org, tglx@linutronix.de, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, mhocko@suse.com, vkuznets@redhat.com, pmladek@suse.com, tj@kernel.org, jpoimboe@redhat.com Subject: [PATCH 1076/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:14:16 +0800 Message-Id: <20160802121416.21855-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- kernel/time/sched_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c index a26036d..9d072c3 100644 --- a/kernel/time/sched_clock.c +++ b/kernel/time/sched_clock.c @@ -71,7 +71,7 @@ struct clock_data { static struct hrtimer sched_clock_timer; static int irqtime = -1; -core_param(irqtime, irqtime, int, 0400); +core_param(irqtime, irqtime, int, S_IRUSR); static u64 notrace jiffy_sched_clock_read(void) { -- 2.9.2