From: Baole Ni <baolex.ni@intel.com>
To: tj@kernel.org, jiangshanlai@gmail.com, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, m.chehab@samsung.com,
gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
kyungmin.park@samsung.com, k.kozlowski@samsung.com
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com,
baolex.ni@intel.com, mhocko@suse.com, tglx@linutronix.de,
vkuznets@redhat.com, pmladek@suse.com, jpoimboe@redhat.com
Subject: [PATCH 1078/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 20:14:26 +0800 [thread overview]
Message-ID: <20160802121426.21987-1-baolex.ni@intel.com> (raw)
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
kernel/workqueue.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index e1c0e99..74d92b0 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -284,11 +284,11 @@ static cpumask_var_t *wq_numa_possible_cpumask;
/* possible CPUs of each node */
static bool wq_disable_numa;
-module_param_named(disable_numa, wq_disable_numa, bool, 0444);
+module_param_named(disable_numa, wq_disable_numa, bool, S_IRUSR | S_IRGRP | S_IROTH);
/* see the comment above the definition of WQ_POWER_EFFICIENT */
static bool wq_power_efficient = IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT);
-module_param_named(power_efficient, wq_power_efficient, bool, 0444);
+module_param_named(power_efficient, wq_power_efficient, bool, S_IRUSR | S_IRGRP | S_IROTH);
static bool wq_numa_enabled; /* unbound NUMA affinity enabled */
@@ -317,7 +317,7 @@ static bool wq_debug_force_rr_cpu = true;
#else
static bool wq_debug_force_rr_cpu = false;
#endif
-module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, 0644);
+module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
/* the per-cpu worker pools */
static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], cpu_worker_pools);
@@ -5423,7 +5423,7 @@ static const struct kernel_param_ops wq_watchdog_thresh_ops = {
};
module_param_cb(watchdog_thresh, &wq_watchdog_thresh_ops, &wq_watchdog_thresh,
- 0644);
+ S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
static void wq_watchdog_init(void)
{
--
2.9.2
next reply other threads:[~2016-08-02 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:14 Baole Ni [this message]
2016-08-02 13:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802121426.21987-1-baolex.ni@intel.com \
--to=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhocko@suse.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®