From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965726AbcHBMyG (ORCPT ); Tue, 2 Aug 2016 08:54:06 -0400 Received: from mga04.intel.com ([192.55.52.120]:8454 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965654AbcHBMx2 (ORCPT ); Tue, 2 Aug 2016 08:53:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="149329117" From: Baole Ni To: davem@davemloft.net, gustavo@padovan.org, johan.hedberg@gmail.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, nikolay@cumulusnetworks.com, nhorman@redhat.com, aduyck@mirantis.com, chuansheng.liu@intel.com, baolex.ni@intel.com, aarcange@redhat.com, aryabinin@virtuozzo.com Subject: [PATCH 1091/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:15:46 +0800 Message-Id: <20160802121546.22862-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- net/core/netpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 94acfc8..fac805d 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -60,7 +60,7 @@ static void zap_completion_queue(void); static void netpoll_async_cleanup(struct work_struct *work); static unsigned int carrier_timeout = 4; -module_param(carrier_timeout, uint, 0644); +module_param(carrier_timeout, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define np_info(np, fmt, ...) \ pr_info("%s: " fmt, np->name, ##__VA_ARGS__) -- 2.9.2