From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965691AbcHBM4v (ORCPT ); Tue, 2 Aug 2016 08:56:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:4832 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965201AbcHBMxx (ORCPT ); Tue, 2 Aug 2016 08:53:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858154684" From: Baole Ni To: gerrit@erg.abdn.ac.uk, davem@davemloft.net, johan.hedberg@gmail.com, jiangshanlai@gmail.com, m.chehab@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aduyck@mirantis.com, aarcange@redhat.com, aryabinin@virtuozzo.com Subject: [PATCH 1095/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:16:10 +0800 Message-Id: <20160802121610.23133-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- net/dccp/proto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 41e6580..dc0eb00 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c @@ -1093,12 +1093,12 @@ static inline void dccp_mib_exit(void) } static int thash_entries; -module_param(thash_entries, int, 0444); +module_param(thash_entries, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(thash_entries, "Number of ehash buckets"); #ifdef CONFIG_IP_DCCP_DEBUG bool dccp_debug; -module_param(dccp_debug, bool, 0644); +module_param(dccp_debug, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dccp_debug, "Enable debug messages"); EXPORT_SYMBOL_GPL(dccp_debug); -- 2.9.2