From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965997AbcHBNAR (ORCPT ); Tue, 2 Aug 2016 09:00:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:30158 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965756AbcHBNAG (ORCPT ); Tue, 2 Aug 2016 09:00:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018237274" From: Baole Ni To: perex@perex.cz, tiwai@suse.com, serge@hallyn.com, davem@davemloft.net, kadlec@blackhole.kfki.hu, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aryabinin@virtuozzo.com Subject: [PATCH 1156/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:21:27 +0800 Message-Id: <20160802122127.27200-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- sound/core/sound.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/sound.c b/sound/core/sound.c index 175f9e4..6c5a4f2 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -41,9 +41,9 @@ static int cards_limit = 1; MODULE_AUTHOR("Jaroslav Kysela "); MODULE_DESCRIPTION("Advanced Linux Sound Architecture driver for soundcards."); MODULE_LICENSE("GPL"); -module_param(major, int, 0444); +module_param(major, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(major, "Major # for sound driver."); -module_param(cards_limit, int, 0444); +module_param(cards_limit, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(cards_limit, "Count of auto-loadable soundcards."); MODULE_ALIAS_CHARDEV_MAJOR(CONFIG_SND_MAJOR); -- 2.9.2