From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966215AbcHBNJR (ORCPT ); Tue, 2 Aug 2016 09:09:17 -0400 Received: from mga01.intel.com ([192.55.52.88]:23657 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966097AbcHBNJF (ORCPT ); Tue, 2 Aug 2016 09:09:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033613991" From: Baole Ni To: perex@perex.cz, tiwai@suse.com, serge@hallyn.com, davem@davemloft.net, kadlec@blackhole.kfki.hu, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aryabinin@virtuozzo.com Subject: [PATCH 1201/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:26:05 +0800 Message-Id: <20160802122605.30259-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- sound/oss/soundcard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c index b70c7c8..af6d4bf 100644 --- a/sound/oss/soundcard.c +++ b/sound/oss/soundcard.c @@ -523,8 +523,8 @@ bad: static int dmabuf; static int dmabug; -module_param(dmabuf, int, 0444); -module_param(dmabug, int, 0444); +module_param(dmabuf, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(dmabug, int, S_IRUSR | S_IRGRP | S_IROTH); /* additional minors for compatibility */ struct oss_minor_dev { -- 2.9.2